Return feature.id in response #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2018 14:15
|
Looks like tests are all failing on linux and only passing on OS X (https://travis-ci.org/mapbox/vtquery/builds/395219301). Sorting is probably the culprit, but not sure yet. Will need to re-read #44 to see if that could be related. |
|
Using |
|
Stable sort changed results locally on OS X, but looks like it means the results are stable between OS X and Linux now: https://travis-ci.org/mapbox/vtquery/builds/395225756 |
stable_sort - refs #90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
feature.idin the response perprocess.env.UPDATEto make it easy to update the fixtures in the future (if needed)From https://tools.ietf.org/html/rfc7946#section-3.2
/cc @mapbox/core-tech